<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122576/">https://git.reviewboard.kde.org/r/122576/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KService is basically ksycoca. One day I hope we can move away from that, which means all of kservice could then be deprecated.
So it still makes sense to <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">use</em> kservice where looking up desktop files is needed (it's our current implementation of that) but KMT itself isn't part of the ksycoca technology, it should be higher up in the stack.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One idea would be to put it in KNewStuff. It's the same kind of thing, viewed from far away: offering the user to install more stuff.</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On March 1st, 2015, 2:28 p.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated March 1, 2015, 2:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If KMoreTools is considered useful it needs a home. I placed it in KService for now.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(34ce792652415100c9a5f877f0516781eb4aec17)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(35154a597f55313847b8140962c0e2a4cf1c15a2)</span></li>
<li>src/kmoretools/kmoretools.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretools.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretools_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretoolsconfigdialog_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretoolsconfigdialog_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/ui/kmoretoolsconfigwidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(cbb5ece6a3265612fa4640426b7025de8f0dc78e)</span></li>
<li>tests/kmoretools/1/a.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/1/b.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/1/c.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/kate.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/kate.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/mynotinstalledapp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/mynotinstalledapp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/kmoretoolstest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122576/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>