<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121317/">https://git.reviewboard.kde.org/r/121317/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 27th, 2015, 7:41 a.m. GMT, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oops, what happened here? Did I forget to review this? Having json metadata for all kded modules sounds like a great idea (especially since kiod requires that, so if some move later to kiod, it will have to be done).</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I thought this is not needed after kiod has been introduced. Are some of the modules here still kded only?</p></pre>
<br />
<p>- Alex</p>
<br />
<p>On February 26th, 2015, 6:53 p.m. GMT, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Sebastian Kügler.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2015, 6:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add JSON metadata to the kded modules</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the converted modules can be loaded</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kssld/kssld.cpp <span style="color: grey">(e3e503af996b411325fab10eb9b3daf5d9617bae)</span></li>
<li>src/kssld/CMakeLists.txt <span style="color: grey">(564602ca73a849758906639b5f07665c995c9a21)</span></li>
<li>src/kpasswdserver/kpasswdserver.cpp <span style="color: grey">(7bd34cc1286acb48e2e0060d97b7fad4cd0a4388)</span></li>
<li>src/kpasswdserver/CMakeLists.txt <span style="color: grey">(21e5c2d17358b3d1233c753d15284cdc790423e0)</span></li>
<li>src/kpac/proxyscout.cpp <span style="color: grey">(375f77503272e700929433c44086f4e213502c6e)</span></li>
<li>src/kpac/CMakeLists.txt <span style="color: grey">(7e6ce1f6cdb992b2ce45ab895aea72df24955fe2)</span></li>
<li>src/kioexec/main.cpp <span style="color: grey">(f0e282394c4f65df0bf52141290d37ba6b32ad8c)</span></li>
<li>src/ioslaves/http/kcookiejar/kcookieserver.cpp <span style="color: grey">(c441496dff316d4e94a4cccdfd46615cd76a7238)</span></li>
<li>src/ioslaves/http/kcookiejar/CMakeLists.txt <span style="color: grey">(890a35bcc24ca043844257f3d2cdd0941ddd1d17)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121317/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>