<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122576/">https://git.reviewboard.kde.org/r/122576/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 22nd, 2015, 1:52 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122576/diff/4/?file=350011#file350011line27" style="color: black; font-weight: bold; text-decoration: underline;">src/kmoretools/kmoretoolsconfigdialog.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "kmoretools_p.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why is a non private header including a private header?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kmoretoolsconfigdialog.h should be private, too. How is this expressed? Also with adding a "_p" to the .h filename (and also to the .cpp filename?)?</p></pre>
<br />
<p>- Gregor</p>
<br />
<p>On February 16th, 2015, 11:05 p.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2015, 11:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If KMoreTools is considered useful it needs a home. I placed it in KService for now.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/kmoretools/kmoretoolstest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/1/b.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/1/c.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/kate.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/kate.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/mynotinstalledapp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/mynotinstalledapp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(e6f8577f193dceda951c25054a134eb5cd2e1cf2)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(35154a597f55313847b8140962c0e2a4cf1c15a2)</span></li>
<li>src/kmoretools/kmoretools.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretools.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretools_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretoolsconfigdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretoolsconfigdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/ui/kmoretoolsconfigwidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(cbb5ece6a3265612fa4640426b7025de8f0dc78e)</span></li>
<li>tests/kmoretools/1/a.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122576/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>