<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122498/">https://git.reviewboard.kde.org/r/122498/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) AFAICS KStartupInfo exists on all platforms nowadays, even if it doesn't do much on other platforms. So the whole HAVE_X11 is unnecesary.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2) the alternative is to change kate.desktop to X-DBUS-StartupType=None. Then klauncher won't wait until DBus registration.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I guess the reason for waiting for DBus registrations are only:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> making it possible to then make dbus calls to the app; but that's not really needed for multi, nor for unique these days with dbus autostart
</em> having a way to report "sorry, it crashed"</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On February 9th, 2015, 11:04 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kate and KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2015, 11:04 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is the patch from bug 339094. As it seemes there's no response/activity to that, I just put it here for proper review (and will commit on behalf of Liu Zhe obviously) as this is really annoying bug. Following is the description by Liu:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Documentation of KToolInvocation (called by KRun when click a file in dolphin) said "Multi" means "Always start a new service, wait until the service has registered with D-Bus". But when the second text file is opened, kate just starts a QApplication and waits, without registering with DBus.
In KDE 4, the second instance of kate launchs an empty KApplication to do this job, but the author said "it's too bad" to register a service. Maybe we can register to make KService happy and unregister at once.
Another problem is that the kate icon will jump quite a few seconds after clicking the second file. I thought the reason was KStartupInfo::appStarted() not called as it requires Q_WS_X11 macro, which is not defined in Qt 5. But the bug still exists after I fixed this.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hrvoje confirmed in the bug report that this indeed fixes the issue.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(408f502)</span></li>
<li>config.h.cmake <span style="color: grey">(d15b78e)</span></li>
<li>kate/src/kateapp.cpp <span style="color: grey">(4c26f33)</span></li>
<li>kate/src/main.cpp <span style="color: grey">(8852754)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122498/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>