<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122555/">https://git.reviewboard.kde.org/r/122555/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122555/diff/1/?file=348635#file348635line39" style="color: black; font-weight: bold; text-decoration: underline;">src/notifybyspeech.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="n">QString</span> <span class="nf">optionName</span><span class="p">()</span> <span class="p">{</span> <span class="k">return</span> <span class="s">"<span class="hl">KTTS</span>"</span><span class="p">;</span> <span class="p">}</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="n">QString</span> <span class="nf">optionName</span><span class="p">()</span> <span class="p">{</span> <span class="k">return</span> <span class="s">"<span class="hl">Speech</span>"</span><span class="p">;</span> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have no idea how this is used, should it be i18n'ed? And Text to Speech</p></pre>
</div>
</div>
<br />
<p>- Frederik Gladhorn</p>
<br />
<p>On February 13th, 2015, 3:11 a.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Frederik Gladhorn.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2015, 3:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add optional dependency on Qt5TextToSpeech for speech notifications.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As I said in the knotifyconfig review something at runtime isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QtSpeech is still in development, so this change is added as an optional dependency.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(208fd02153a0607e4cfbc02e4b289ef835cedbfd)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9)</span></li>
<li>src/knotification.h <span style="color: grey">(c85621699793436442090b7f94ea82ef10c45b89)</span></li>
<li>src/knotificationmanager.cpp <span style="color: grey">(affb6a673468bf6585cbda6fafdd008beb445cd9)</span></li>
<li>src/kstatusnotifieritem.h <span style="color: grey">(113dad513c320ef97f59b221b3541ca2f388693e)</span></li>
<li>src/notifybyktts.h <span style="color: grey">(43756f776678bd7700a77a3357577363b36d2542)</span></li>
<li>src/notifybyktts.cpp <span style="color: grey">(a2a15a9c77089527f54dfc63f13699d44336dda1)</span></li>
<li>src/notifybyspeech.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122555/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>