<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122554/">https://git.reviewboard.kde.org/r/122554/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 13th, 2015, 11:49 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What's the status of QtSpeech?</p></pre>
</blockquote>
<p>On February 13th, 2015, 7:42 p.m. UTC, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll blog about it shortly.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think QtSpeech is Qt 5.6 material realistically. It's usable on most platforms but needs cleanup and API review and a couple of features are not done on all platforms.</p></pre>
<br />
<p>- Frederik</p>
<br />
<p>On February 13th, 2015, 7:42 p.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Frederik Gladhorn.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2015, 7:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifyconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change config from KTTS to Speech.
If QtSpeech is available when building return true from have_speech static method.
Otherwise return false.
Could also add a check to see if there are any backend errors later on.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Something strange here:
After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case).
Similarly, after disabling this notification, messages are still spoken until restarting the application.
I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f5aa0e78d89a4c14c3acfd9384b100e507e30067)</span></li>
<li>src/knotifyconfigactionswidget.h <span style="color: grey">(88b341a909d466b8eaf065c5220ac05f8c963697)</span></li>
<li>src/knotifyconfigactionswidget.cpp <span style="color: grey">(27012e3b803ef0a99d5bafcebea270e2d7419d62)</span></li>
<li>src/knotifyconfigactionswidgetbase.ui <span style="color: grey">(cbe647b70eb41ba540b7bf6d87f519b3246973a1)</span></li>
<li>src/knotifyconfigelement.h <span style="color: grey">(703952d23d1622e4b6214acc52461ea75b480254)</span></li>
<li>src/knotifyconfigelement.cpp <span style="color: grey">(5a1ac57fa5a4139682327d14c55a489450ea956b)</span></li>
<li>src/knotifyeventlist.cpp <span style="color: grey">(148bca7d33c722a4aeecabac45286a5e501c81b3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122554/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>