<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122396/">https://git.reviewboard.kde.org/r/122396/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Klapetek.</div>
<div>By Xuetian Weng.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">knotifyconfig in notify would not be free'd in many case. This patch pass const reference instead of pointer to plugin. And add a copy constructor to KNotifyConfig, so it's not possible to leak anymore.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Though API/ABI is changed, knotifyconfig.h is never installed before, which also makes knotificationplugin somewhat useless. And seems there is no knotificationplugin user yet.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/notifybypopup.h <span style="color: grey">(a605a77)</span></li>
<li>src/notifybypopup.cpp <span style="color: grey">(2f08146)</span></li>
<li>src/notifybytaskbar.h <span style="color: grey">(0908787)</span></li>
<li>src/notifybytaskbar.cpp <span style="color: grey">(b52e180)</span></li>
<li>src/knotificationmanager.cpp <span style="color: grey">(3cf637c)</span></li>
<li>src/knotificationplugin.h <span style="color: grey">(3438e7d)</span></li>
<li>src/knotificationplugin.cpp <span style="color: grey">(7315c17)</span></li>
<li>src/knotifyconfig.h <span style="color: grey">(fae17cb)</span></li>
<li>src/knotifyconfig.cpp <span style="color: grey">(af6be92)</span></li>
<li>src/notifybyaudio.h <span style="color: grey">(9a2d531)</span></li>
<li>src/notifybyaudio.cpp <span style="color: grey">(d7090ac)</span></li>
<li>src/notifybyexecute.h <span style="color: grey">(ae362e3)</span></li>
<li>src/notifybyexecute.cpp <span style="color: grey">(b5d437a)</span></li>
<li>src/notifybyktts.h <span style="color: grey">(43756f7)</span></li>
<li>src/notifybyktts.cpp <span style="color: grey">(a2a15a9)</span></li>
<li>src/notifybylogfile.h <span style="color: grey">(6ea2850)</span></li>
<li>src/notifybylogfile.cpp <span style="color: grey">(ca3faf9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122396/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>