<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122140/">https://git.reviewboard.kde.org/r/122140/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122140/diff/1/?file=342940#file342940line1413" style="color: black; font-weight: bold; text-decoration: underline;">src/netwm.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1413</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">xcb_pixmap_t</span> <span class="n">iconPixmap</span><span class="p">()</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"icccmIconPixmap()" and a comment to in doubt preferably use the ::icon(int, int) function (for this is a legacy feature w/ reduced functionality)?</p></pre>
</div>
</div>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On Januar 19th, 2015, 11:03 vorm. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2015, 11:03 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">WM_HINTS property is already read and this provides the icon pixmap
and icon mask hint as read from WM_HINTS. This can be used for example
in KWindowSystem::icon which currently uses an XLib call.
Use NETWinInfo's WM2WindowClass and WM2IconPixmap in KWindowSystemPrivateX11::icon
Instead of using an XLib call the wrapper from NETWinInfo is used.
This reduces the number of roundtrips to the X server in case flags
includes both NETWM, ClassHint and WMHints.
In additon we don't need the deprecated x error eater any more.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/netwininfotestclient.cpp <span style="color: grey">(a0fdc403bb8329ea9fde786494bc0ccf88a8ebfd)</span></li>
<li>src/kwindowsystem_x11.cpp <span style="color: grey">(bf958ae63b48424fc412405259f082b740928f9a)</span></li>
<li>src/netwm.h <span style="color: grey">(382ab460867905fdf0a4106a271e6614478fb438)</span></li>
<li>src/netwm.cpp <span style="color: grey">(1c96aaf9e480842c0b5379c89722f2e91a664476)</span></li>
<li>src/netwm_def.h <span style="color: grey">(49d02035eaec402a61e0b17b377b27c80d605b7b)</span></li>
<li>src/netwm_p.h <span style="color: grey">(0f1dd62ecd9c856e028dd33d28d461ed7099f60b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122140/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>