<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121471/">https://git.reviewboard.kde.org/r/121471/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just like we have KFileWidget for an embeddable file-selection-widget, we could very well have a KDirSelectWidget for an embeddable dir-selection-widget.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The code is currently in frameworkintegration/src/platformtheme/kdirselectdialog.cpp (and duplicated in kdelibs4support).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think it would be a valid solution to extract a widget out of it and put it in kio/src/filewidgets.
The design should match KFileWidget as much as possible.</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On December 17th, 2014, 11:58 a.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Bhushan Shah, David Faure, Lukáš Tinkl, and Laurent Montel.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2014, 11:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I ported KDirSelectDialog to QFileDialog to get rid of kdelibs4support in ExtractionDialog, but I run into one problem. This dialog needs to add additional config widget, this is possible with using setExtension(widget) or directly accessing layout and adding this widget directly to the layout. Problem is that both options work only when I don't use native file dialog, not mentioning that setExtension() is obsoleted and accesing directly to layout of QFileDialog relies on knowning internal implementation in Qt so if they change it, i.e they switch to another layout then QGridLayout, then it will be broken again. I also tried to implement own QFileDialog using KFileWidget, but problem is that KFileWidget works only for files and I need to select a directory. You can set option to display just directories, but selecting directories is unfortunately ignored. I'm open to a better solution, but I've spent quite a lot of time trying to find it, but unfortunately without any success.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/batchextract.cpp <span style="color: grey">(9480e99)</span></li>
<li>kerfuffle/extractiondialog.h <span style="color: grey">(5907403)</span></li>
<li>kerfuffle/extractiondialog.cpp <span style="color: grey">(f602861)</span></li>
<li>part/part.cpp <span style="color: grey">(82d6f9c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121471/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>