<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121233/">https://git.reviewboard.kde.org/r/121233/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On December 1st, 2014, 2:02 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Dec. 1, 2014, 2:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDesktopFileActions::run did not accept the optional argument
QByteArray asn which meant that any application startup id passed
to KRun got dropped at this point when launching a desktop file.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This change ensures that an ASN is passed along. This way we can
properly pass around the application which launched the process
and the timestamp which triggered the launch (otherwise klauncher
needs a roundtrip to the X-Server to fetch the latest timestamp).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/kdesktopfileactions.h <span style="color: grey">(7b96ff079c752436aebd0b134b930171ea088f48)</span></li>
<li>src/widgets/kdesktopfileactions.cpp <span style="color: grey">(0cbeb00f0c0344b5b204f0d18b7c269da6c99e7f)</span></li>
<li>src/widgets/krun.cpp <span style="color: grey">(c623b583716e492622e0d1d1c9cec485c6bcf163)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121233/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>