<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121118/">https://git.reviewboard.kde.org/r/121118/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Depending on the addition of 121094 first ...</p></pre>
<br />
<p>- Aaron J. Seigo</p>
<br />
<p>On November 25th, 2014, 9:39 a.m. UTC, Daniel Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Albert Astals Cid and David Faure.</div>
<div>By Daniel Vrátil.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2014, 9:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kemoticons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is related to /r/121094, which moves KTextToHTML conversion utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on KEmoticons needed for smileys conversion, I created a plugin in KEmoticons that implements the interface from KCoreAddons. This is based on the FrameworkIntegrationPlugin.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1550bfe)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(29b7eb6)</span></li>
<li>autotests/ktexttohtmlplugintest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(7b10087)</span></li>
<li>src/integrationplugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/integrationplugin/kemoticonsintegrationplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/integrationplugin/kemoticonsintegrationplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/integrationplugin/ktexttohtml.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/integrationplugin/ktexttohtml.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121118/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>