<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118946/">https://git.reviewboard.kde.org/r/118946/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 26th, 2014, 7:29 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is however not ABI relevant, so depending on schedules one *could* wait for some specified NETWM hint (to not cruft the lib with the gtk+ prop symbol: removing it from the enum is oc. not API stable, thus not possible) and be introduced even with KWin 5.0.3 or whatever the final name scheme will be ;-)</pre>
</blockquote>
<p>On June 26th, 2014, 7:32 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yeah I'm fine with delaying to post 5.0 in frameworks. Means KWin 5.0 will not have full support for it. But if it gets into KWindowSystem 5.1 we can still add it in a minor KWin relase (and get killed by distros for increasing requirement in a minor release :-P ).</pre>
</blockquote>
<p>On June 26th, 2014, 7:53 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if this is causing downstream dep issues, maybe a generic NETRootInfo::setSupported(const QString property) might be a good idea?</pre>
</blockquote>
<p>On June 26th, 2014, 8:01 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could be something to look into for 5.1, good idea.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">5.1 has been and gone. What's the status of this?</p></pre>
<br />
<p>- David</p>
<br />
<p>On June 26th, 2014, 7:22 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 26, 2014, 7:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2
Although non-standard it needs to be added to the NET::PRoperties2
in order to have KWin announce it in the supported section.
As soon as this gets standardized WM2ShowWindowMenu can be changed
to point to both the proprietary GTK hint and the standardized hint.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/netrootinfotestwm.cpp <span style="color: grey">(f8c28be51e5a5b19d436c54eede0e8659a65c84e)</span></li>
<li>src/netwm.cpp <span style="color: grey">(1daad1e5fc87fa85da6348a059d0ae0acec26eaf)</span></li>
<li>src/netwm_def.h <span style="color: grey">(0edadc085e08531ec81bcde5651e8475e8573091)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118946/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>