<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121230/">https://git.reviewboard.kde.org/r/121230/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Martin Gräßlin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The code was hard disabled due to usage of Q_WS_X11. The task is
to get the startupid passed to kioexec and forward it to the
process started by kioexec. As Qt's xcb plugin removes the
DESKTOP_STARTUP_ID environment variable once it is read, this needs
special handling to setup the enivornment for the process to be
started.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unfortunately the fix requires Qt 5.4 as the startupId is only
provided by QX11Extras since 5.4.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">used
DESKTOP_STARTUP_ID="FOO" kioexec "gwenview %U" file:///path/to/local/file.png</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">with and without the change and inspected /proc/x/environ for the started gwenview process. Without the patch DESKTOP_STARTUP_ID is not set, with the patch it's properly set to "FOO" in this case.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(888edff2bee476b4d2098b375a38a2b3a86135e8)</span></li>
<li>src/kioexec/CMakeLists.txt <span style="color: grey">(6c587e19310a5395f0db455f48fe18a27e9ec386)</span></li>
<li>src/kioexec/config-kioexec.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kioexec/main.cpp <span style="color: grey">(f0e282394c4f65df0bf52141290d37ba6b32ad8c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121230/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>