<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121178/">https://git.reviewboard.kde.org/r/121178/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Daniel Vrátil.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Nov. 19, 2014, 10:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This was a new bug introduced by kcodecs' commit ca74c40ab79cb8d5fbffc4418c83a53071040218</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">[ <span style="color: #666666">92%</span>] [ <span style="color: #666666">93%</span>] Building CXX object.o
Undefined symbols <span style="color: #008000; font-weight: bold">for</span> architecture x86_64<span style="color: #666666">:</span>
<span style="color: #BA2121">"KCodecs::base64Encode(QByteArray const&)"</span>, referenced from<span style="color: #666666">:</span>
testCodec(<span style="color: #B00040">char</span> <span style="color: #008000; font-weight: bold">const</span><span style="color: #666666">*</span>, Codec, <span style="color: #B00040">bool</span>) in kmdcodectest.cpp.o
<span style="color: #A0A000">ld:</span> symbol(s) not found <span style="color: #008000; font-weight: bold">for</span> architecture x86_64
Built target kfiletreeviewtest
<span style="color: #A0A000">clang:</span> error<span style="color: #666666">:</span> linker command failed with exit code <span style="color: #666666">1</span> (use <span style="color: #666666">-</span>v to see invocation)
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [tests<span style="color: #666666">/</span>kmdcodectest.app<span style="color: #666666">/</span>Contents<span style="color: #666666">/</span>MacOS<span style="color: #666666">/</span>kmdcodectest] Error <span style="color: #666666">1</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [tests<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>kmdcodectest.dir<span style="color: #666666">/</span>all] Error <span style="color: #666666">2</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> Waiting <span style="color: #008000; font-weight: bold">for</span> unfinished jobs....
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and can be fixed by adding the boolean parameter explicitely.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds fine on OSX/CI</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/kmdcodectest.cpp <span style="color: grey">(fb0902f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121178/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>