<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121090/">https://git.reviewboard.kde.org/r/121090/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 12th, 2014, 10:04 p.m. UTC, <b>Àlex Fiestas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would move this perhaps to plasma-workspace since this slave is really important for nowadays usage of the desktop (android phones etc).</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, there's important kio's as well in kio-extras. Question is, is it useful outside the workspace? Would a cross-platform application use it?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems to me they would, I can see amarok requiring it even on windows or gnome.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On November 10th, 2014, 9:30 a.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Philipp Schmidt.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2014, 9:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch moves kio-mtp from its frameworks branch to kio-extras. I believe that this kioslave should be with the rest and not alone somewhere without release. I also formatted it a bit to follow kdelibs coding style.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Discussion about this move can be found here http://lists.kde.org/?l=kde-devel&m=141500903106761&w=2</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tested copying files, creating and removing folders in Dolphin with my Nexus 4 and everything seems to work fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mtp/kio_mtp_helpers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio_mtp_helpers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/mtp-network.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/mtp.protocol <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/solid_mtp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/filecache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio-mtp.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio_mtp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio_mtp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(8f82688)</span></li>
<li>mtp/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/COPYING <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/LICENCE <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/devicecache.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/devicecache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/filecache.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121090/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>