<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121100/">https://git.reviewboard.kde.org/r/121100/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2014, 2:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add qCDebug statements back into knewstuff sources.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds and works still, more debug output filterable with the kanagram logging category.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/knewstuff2_standard.cpp <span style="color: grey">(e44628b549ea5ad3b002c3a11eac298b92b5a6ae)</span></li>
<li>tests/khotnewstuff.cpp <span style="color: grey">(1aba7de48a8b7cf7f8886957fc473bf0cc631a13)</span></li>
<li>tests/knewstuff2_cache.cpp <span style="color: grey">(e7e8a48666237f468d986e99a8c472fe37fd7a77)</span></li>
<li>tests/knewstuff2_download.cpp <span style="color: grey">(39d756e30f5b4f56f9254ae1e08c0d8310daf4d1)</span></li>
<li>src/staticxml/staticxmlprovider.cpp <span style="color: grey">(434ecef0b71543bf4504c9781d1d3a21b9cf6e34)</span></li>
<li>src/ui/entrydetailsdialog.cpp <span style="color: grey">(8a36d33f9a390a211313b11fba65030261a54446)</span></li>
<li>src/ui/itemsgridviewdelegate.cpp <span style="color: grey">(19ddc59eb4acbb2b7a591119453be407d01d9a9f)</span></li>
<li>src/ui/itemsmodel.cpp <span style="color: grey">(0254e88a5c16a2f8c5818a45bb7ec28eef4973e8)</span></li>
<li>src/ui/itemsviewbasedelegate.cpp <span style="color: grey">(5137beb93ee8cccd15b28b9a9f47eff60fc17fc8)</span></li>
<li>src/ui/itemsviewdelegate.cpp <span style="color: grey">(5e9b985cc155d141664a944b3d2bd1e751d96136)</span></li>
<li>src/uploaddialog.cpp <span style="color: grey">(1a087b30a7fc6198062f0f7a012ae37ed6f396af)</span></li>
<li>src/core/engine.cpp <span style="color: grey">(017154323cfd3f48fc61c0c705d4842f3c2f94a4)</span></li>
<li>src/core/entryinternal.cpp <span style="color: grey">(d3af619e9908b2f9e6176c7c87eda44897e93f0a)</span></li>
<li>src/core/installation.cpp <span style="color: grey">(d8de905bd2d19d098fb08a64897f5617f04e996d)</span></li>
<li>src/core/upload.cpp <span style="color: grey">(166e69417b687fef6e89ef7fb5c383ec478c5c2d)</span></li>
<li>src/core/xmlloader.cpp <span style="color: grey">(2cee02b66f8ec2a0f1fc407aaadd0ea397b89939)</span></li>
<li>src/downloadmanager.cpp <span style="color: grey">(60d0d37ef0bd35efdcfe5e6ac58fefb3a2ce9954)</span></li>
<li>src/downloadwidget.cpp <span style="color: grey">(358bb8b5222ac596dd3f0025778cd2721c1f3120)</span></li>
<li>src/entry.h <span style="color: grey">(df3095e3f75d2f6ca15daf9e87172990214d6352)</span></li>
<li>src/entry.cpp <span style="color: grey">(48a92a7db04eec9b7b1b824841c95c280f31fab7)</span></li>
<li>autotests/knewstuffentrytest.cpp <span style="color: grey">(bf55f063dc8cb0b0984fdc73501a13107241a75a)</span></li>
<li>src/attica/atticaprovider.cpp <span style="color: grey">(7103b59d62de468ba0c21a6b6260e5befc8575a2)</span></li>
<li>src/core/cache.cpp <span style="color: grey">(3ba6cb4f4d344781d7b95c966d0a0643777e1e6a)</span></li>
<li>tests/knewstuff2_test.cpp <span style="color: grey">(ee2ead451be06854ea65ee9128231d37b118355c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121100/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>