<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120728/">https://git.reviewboard.kde.org/r/120728/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2014, 10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename the class to KNotificationPlugin</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Install public header for KNotifyPlugin and rename it to KNotificationPlugin</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">...to allow custom KNotification plugins. This class is being exported since ever, but the public header was missing.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, I'd like to rename this class to KNotificationPlugin rather than KNotifyPlugin as there is no KNotify anymore, but renaming already exported class is not allowed in frameworks as that would break BC, right?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/knotificationplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knotifyplugin.h <span style="color: grey">(248a66f)</span></li>
<li>src/knotifyplugin.cpp <span style="color: grey">(e2efab9)</span></li>
<li>src/notifybyaudio.h <span style="color: grey">(767f1ce)</span></li>
<li>src/notifybyaudio.cpp <span style="color: grey">(99b8027)</span></li>
<li>src/notifybyexecute.h <span style="color: grey">(92781ef)</span></li>
<li>src/notifybyexecute.cpp <span style="color: grey">(254341a)</span></li>
<li>src/notifybyktts.h <span style="color: grey">(a05eebf)</span></li>
<li>src/notifybyktts.cpp <span style="color: grey">(71f9ae5)</span></li>
<li>src/notifybylogfile.h <span style="color: grey">(32a8ae5)</span></li>
<li>src/notifybylogfile.cpp <span style="color: grey">(fa0c103)</span></li>
<li>src/notifybypopup.h <span style="color: grey">(36aac1d)</span></li>
<li>src/notifybypopup.cpp <span style="color: grey">(c7add40)</span></li>
<li>src/notifybysound.h <span style="color: grey">(44f6463)</span></li>
<li>src/notifybysound.cpp <span style="color: grey">(f005b99)</span></li>
<li>src/notifybytaskbar.h <span style="color: grey">(83d46ce)</span></li>
<li>src/notifybytaskbar.cpp <span style="color: grey">(173bbb8)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(5b109c8)</span></li>
<li>src/knotification.h <span style="color: grey">(456e84b)</span></li>
<li>src/knotificationmanager.cpp <span style="color: grey">(f44c660)</span></li>
<li>src/knotificationmanager_p.h <span style="color: grey">(19bb823)</span></li>
<li>src/knotificationplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120728/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>