<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120574/">https://git.reviewboard.kde.org/r/120574/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think it's not allowed (though better ask Kevin or David) in which case I suggest: // TODO: KF6 make explicit</p></pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On October 14th, 2014, 12:49 a.m. CEST, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Jeremy Whiting.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2014, 12:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add explicit to ctors with one parameter</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds and khotnewstuff test app still works.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My only question is if this source incompatible change is allowed in frameworks or not.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/attica/atticaprovider_p.h <span style="color: grey">(8638aff0e6548705a22f125a7adc25ff6b1db165)</span></li>
<li>src/button.h <span style="color: grey">(155b6dc5f4b032970bcd0e5400cf5dba12f76e81)</span></li>
<li>src/core/engine_p.h <span style="color: grey">(f7a6884d9a22c56f1feff8b6c97fa242f46533da)</span></li>
<li>src/core/installation_p.h <span style="color: grey">(9d855a26590dcee2259fe657fc7c3293669e3f81)</span></li>
<li>src/core/xmlloader_p.h <span style="color: grey">(7167417c1fcfbeafea1ceb9c7cb5eb56b9d8ac29)</span></li>
<li>src/downloadwidget_p.h <span style="color: grey">(37c7f0872fe0ff6fe65ab7bc63e1239f1b0d8e36)</span></li>
<li>src/ui/itemsview_p.h <span style="color: grey">(df65d0b47abaddd404a171890e47af1b93c4203f)</span></li>
<li>src/ui/progressindicator_p.h <span style="color: grey">(3d18bff8eac6b8a21f94da39b21b51ee334ec3de)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120574/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>