<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120480/">https://git.reviewboard.kde.org/r/120480/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2014, 3:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply checking ~/.kde then ~/.kde4.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
but in Plasma5 we need to be really sure where ~/.kde is since some settings are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to create it from kf5, that's why the kdehome() method)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 configs in user homes is very possible)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with _KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of distributions to make this right.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
on the other hand if the user changes distribution at the moment of the migration between kde4 and plasma5 this may break.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/util/config-kde4home.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/util/kdelibs4migration.cpp <span style="color: grey">(e1ec678)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(5ae5c08)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120480/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>