<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120479/">https://git.reviewboard.kde.org/r/120479/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for the new template. The patch looks good to me, only a few small issues :)</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120479/diff/1/?file=316431#file316431line1" style="color: black; font-weight: bold; text-decoration: underline;">templates/C++/kde-frameworks5/icons/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">ecm_install_icons</span><span class="p">(</span> <span class="o">${</span><span class="nv">ICON_INSTALL_DIR</span><span class="o">}</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As bshah said, ecm_install_icons has some new required parameters: In the end it looks like ecm_install_icons(ICONS ${var_with_icons} DESTINATION ${ICON_INSTALL_DIR} THEME hicolor)</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120479/diff/1/?file=316439#file316439line29" style="color: black; font-weight: bold; text-decoration: underline;">templates/C++/kde-frameworks5/src/%{APPNAMELC}.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">%</span><span class="p">{</span><span class="n">APPNAMELC</span><span class="p">}</span><span class="n">View</span> <span class="o">=</span> <span class="k">new</span> <span class="o">%</span><span class="p">{</span><span class="n">APPNAME</span><span class="p">}</span><span class="n">View</span><span class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Clang is complaining about the same variable and class name (Build error)</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120479/diff/1/?file=316449#file316449line46" style="color: black; font-weight: bold; text-decoration: underline;">templates/C++/kde-frameworks5/src/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">application</span><span class="p">.</span><span class="n">setWindowIcon</span><span class="p">(</span><span class="n">QIcon</span><span class="o">::</span><span class="n">fromTheme</span><span class="p">(</span><span class="s">"%{APPNAMELC}"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is a missing KAboutData::setApplicationData(aboutData);. That means, the about dialog will not show the application/author information (Help --> About Simple App)</p></pre>
</div>
</div>
<br />
<p>- Simon Wächter</p>
<br />
<p>On October 3rd, 2014, 4:27 p.m. CEST, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Simon Wächter.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2014, 4:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kapptemplate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port KDE 4 template to KDE Frameworks<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
also fix docs compile</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">sample generated app: http://starsky.19inch.net/~jr/tmp/jonathan.tar.gz</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">run kapp template, exported, compiled and installed a sample app</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(02df39d6cc0065d1ea95cf236cf4089a40ad6299)</span></li>
<li>templates/C++/kde-frameworks5/kde-frameworks5.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/%{APPNAMELC}.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/%{APPNAMELC}.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/%{APPNAMELC}.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/%{APPNAMELC}ViewBase.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/%{APPNAMELC}ui.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/%{APPNAMELC}view.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/COPYING <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/COPYING.DOC <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/doc/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/doc/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/icons/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/icons/hi16-apps-%{APPNAMELC}.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/icons/hi22-apps-%{APPNAMELC}.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/icons/hi32-apps-%{APPNAMELC}.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/icons/hi48-apps-%{APPNAMELC}.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/icons/hisc-apps-%{APPNAMELC}.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/kde-frameworks5.kdevtemplate <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/index.docbook <span style="color: grey">(b3edf623aeac322e4775028a5d7502d80dff7327)</span></li>
<li>templates/C++/CMakeLists.txt <span style="color: grey">(6f31aa3cc7a68748c82965b525c0f7eb7b956652)</span></li>
<li>templates/C++/kde-frameworks5/src/settingsBase.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/%{APPNAMELC}view.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/%{APPNAME}Settings.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/%{APPNAME}Settings.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5/src/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120479/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>