<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120217/">https://git.reviewboard.kde.org/r/120217/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If we merge, we should imo merge in NetWinInfo - having the same function return different values in NetWinInfo and KWindowInfo feels wrong.</p></pre>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On September 15th, 2014, 1:29 nachm. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Sept. 15, 2014, 1:29 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If WM2Urgency is passed to the ctor of KWindowInfo, ::state() checks
the urgency state is set and adds NET::DemandsAttention. This allows
to easily check whether the window demands attention either through
EWMH or ICCCM.
The change does not affect existing code as one has to explicitly
pass WM2Urgency and this one is new in 5.3, too.
This change only affects platform X11.
CHANGELOG: KWindowInfo::state can map urgency to NET::DemandsAttention</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kwindowinfox11test.cpp <span style="color: grey">(3ff6a49447a99d9afdabe6c96361b276083de525)</span></li>
<li>src/kwindowinfo.h <span style="color: grey">(b00e115f293231b661934d20e97be4d186f679de)</span></li>
<li>src/kwindowinfo_x11.cpp <span style="color: grey">(2a32692a0f664d6a9884e6d1a1209e88e02944ec)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120217/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>