<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120186/">https://git.reviewboard.kde.org/r/120186/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 13th, 2014, 4:20 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Cool, looks like a no-brained to me. Could we also wrap these things in anonymous namespaces to give them file-local linkage?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Right, there's still 9256 bytes in .data.rel.ro, at least half of which we can probably get to .rodata as well. Note the extern declarations at the end though, they block giving them file-local linkage at the moment. I'll do another pass over frameworks looking into that specifically once I'm done with looking at .data and .bss optimizations.</p></pre>
<br />
<p>- Volker</p>
<br />
<p>On September 13th, 2014, 4:02 p.m. UTC, Volker Krause wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Volker Krause.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2014, 4:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcodecs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This reduces the size of the .data section from 4232 bytes to just 8, thus
reducing per-process memory overhead.
These files are based on Mozilla code, which seems to contain the same
change by now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/probers/nsEscSM.cpp <span style="color: grey">(0927ecf18fbf27e6ec3450c9ed5aa37482c953c6)</span></li>
<li>src/probers/nsLatin1Prober.cpp <span style="color: grey">(ea164149291f64bec0498c28ec04ff1cf098de4c)</span></li>
<li>src/probers/nsMBCSSM.cpp <span style="color: grey">(3913b901820baa5722b5a6906cdf4009493cc266)</span></li>
<li>src/probers/nsPkgInt.h <span style="color: grey">(2a3b5742fd3f5158e4dc6f523e7dfd5ef7f7ad22)</span></li>
<li>src/probers/nsSBCharSetProber.h <span style="color: grey">(30bd8baee984ad661e42f0785d8276adad0a97b3)</span></li>
<li>src/probers/LangHungarianModel.cpp <span style="color: grey">(82add0e7c8bd43e4bf56f60ce8cd381dd0a2889c)</span></li>
<li>src/probers/LangThaiModel.cpp <span style="color: grey">(72c44b30978e7b15d593c8c7a8b6a20b4407a942)</span></li>
<li>src/probers/nsCodingStateMachine.h <span style="color: grey">(6eb00189fbc25dbd40e68692065e2542c88aa156)</span></li>
<li>src/probers/LangCyrillicModel.cpp <span style="color: grey">(cff257b4f3df5f8835ce1e5108684f82f21c5340)</span></li>
<li>src/probers/LangGreekModel.cpp <span style="color: grey">(5791314324776b1a7e13eec567861e6993aa0239)</span></li>
<li>src/probers/LangHebrewModel.cpp <span style="color: grey">(30483ce2de2521eea0025b77ab1ea17bbf4f2b77)</span></li>
<li>src/probers/LangBulgarianModel.cpp <span style="color: grey">(322d2e6e7e4dd5d049c0212da823b12cbbc48b91)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120186/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>