<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120173/">https://git.reviewboard.kde.org/r/120173/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a pretty complex problem area. I hesitantly agree that adding the Unicode emojis to KEmoticons is probably a good stopgap solution (and I'd recommend also adding DoCoMo's private area mappings, since they're widely used as well by Asian IM services).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Longer-term though, with emoji rendering moving into font stack (either using Microsoft's layer glyphs extension, or Mozilla's embedded SVG glyphs) we'll have to consider whether keeping KEmoticons in the present form makes sense. Most user-desirable themes will be circulated as fonts by that point, since OpenType is obviously more widely supported than KEmoticon's theme format.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Emoji support then mostly becomes an input problem on the desktop end, i.e. it's about how to easily input emoji code points and string replacement from things like ":)" makes more sense sender-side than recipient-side. KEmoticons should probably provide something for that, and maybe also a simple graphical emoji IME.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Theme support then becomes a font settings problem - cf. also https://blogs.kde.org/2014/09/11/beyond-unicode-closing-gap-support-mixed-character-set-text-kde-workspaces</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So ... +1 for now, but that's not the last time we'll talk emoji I guess ...</p></pre>
<br />
<p>- Eike Hein</p>
<br />
<p>On September 12th, 2014, 9:17 p.m. UTC, David Gil Oliva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2014, 9:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kemoticons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KEmoticons can't correctly parse unicode emoticons. They mostly show as little squares or (some of them) as little black and white emoticons, but they aren't parsed to the emoticons in the Glass theme.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds unicode emoticons to the emoticons.xml file so that they are translated to the theme images.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The problem is that the available themes don't have enough emoticons and some information is lost in the translation, but that can only be fixed with a complete theme that someone has to make. Fortunately, some people are already working on it [1] :-D .</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The codes of the unicode characters that I have added can be seen with 'less' for review. Otherwise, I don't know how it can be reviewed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] https://forum.kde.org/viewtopic.php?f=285&t=122712</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tested with kemoticonstest, in the test folder.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It doesn't work with Qt 5.2. It works with Qt 5.4. I haven't tested with Qt 5.3.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>themes/Glass/emoticons.xml <span style="color: grey">(dad55e2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120173/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>