<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120165/">https://git.reviewboard.kde.org/r/120165/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120165/diff/1/?file=311784#file311784line4102" style="color: black; font-weight: bold; text-decoration: underline;">src/netwm.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void NETWinInfo::update(NET::Properties dirtyProperties, NET::Properties2 dirtyProperties2)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4099</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">dirty2</span> <span class="o">&</span> <span class="n">WM2GroupLeader</span><span class="p">)</span> <span class="o">||</span> <span class="p">(</span><span class="n">dirty2</span> <span class="o">&</span> <span class="n">WM2Urgency</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4102</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">dirty2</span> <span class="o">&</span> <span class="n">WM2GroupLeader</span><span class="p">)</span> <span class="o">||</span> <span class="p">(</span><span class="n">dirty2</span> <span class="o">&</span> <span class="n">WM2Urgency</span><span class="p">)</span><span class="hl"> </span><span class="o"><span class="hl">||</span></span><span class="hl"> </span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">dirty2</span></span><span class="hl"> </span><span class="o"><span class="hl">&</span></span><span class="hl"> </span><span class="n"><span class="hl">WM2Input</span></span><span class="p"><span class="hl">)</span>)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"if (dirty2 & (WM2GroupLeader|WM2Urgency|WM2Input))" ?</p></pre>
</div>
</div>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On September 12th, 2014, 2:07 nachm. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2014, 2:07 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Input Hint is part of WM_HINTS property which is already processed
for WM2GroupLeader and WM2Urgency.
The default for input hint is true. ICCCM suggests to assume convenient
values for all fields of WM_HINTS property if a window is mapped wihtout
one. KWin sets this value to true, so the sane convenient value for the
input field seems to be true.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/netwininfotestclient.cpp <span style="color: grey">(160f7599f3fba9398029db3be5841fe78bbf7cf0)</span></li>
<li>src/netwm.h <span style="color: grey">(0c89dc7385e2542e6e21da55985fd8b926fb3e37)</span></li>
<li>src/netwm.cpp <span style="color: grey">(a0a2faeeb1dea432a7c2d1e72800de3cf6cb6d2a)</span></li>
<li>src/netwm_def.h <span style="color: grey">(0edadc085e08531ec81bcde5651e8475e8573091)</span></li>
<li>src/netwm_p.h <span style="color: grey">(2e4659e53adb3975d69f0bfffb88d26c0148edd6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120165/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>