<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119711/">https://git.reviewboard.kde.org/r/119711/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119711/diff/2/?file=303743#file303743line503" style="color: black; font-weight: bold; text-decoration: underline;">src/kdeinit/kinit.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static pid_t launch(int argc, const char *_name, const char *args,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">503</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">libpath</span> <span class="o">=</span> <span class="n">QString</span><span class="p">(</span><span class="n">lib</span><span class="p">).</span><span class="n">replace</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="n"><span class="hl">KF5_LIBEXEC</span>_INSTALL_DIR</span><span class="p">),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">503</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">libpath</span> <span class="o">=</span> <span class="n">QString</span><span class="p">(</span><span class="n">lib</span><span class="p">).</span><span class="n">replace</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="n"><span class="hl">CMAKE</span>_INSTALL_<span class="hl">FULL_LIBEXEC</span>DIR<span class="hl">_KF5</span></span><span class="p">),</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This can't work, it's replacing a full path with a relative path.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The goal of this code was s/libexec/lib/ AFAICS,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
just like the next block does s/bin/lib/<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
(and then they append the filename).</p></pre>
</div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On August 11th, 2014, 2:22 p.m. UTC, Nicolas Lécureuil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Nicolas Lécureuil.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2014, 2:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Resolves the problem of passing relative vs. absolute KF5_LIBEXEC_INSTALL_DIR/LIBEXEC_INSTALL_DIR. </p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Before it searches for /usr//usr/libexec and after all is fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/config-kdeinit.h.cmake <span style="color: grey">(76cd867)</span></li>
<li>src/kdeinit/CMakeLists.txt <span style="color: grey">(8a84774)</span></li>
<li>src/kdeinit/kinit.cpp <span style="color: grey">(296ebfd)</span></li>
<li>src/klauncher/CMakeLists.txt <span style="color: grey">(8a251ff)</span></li>
<li>src/klauncher/klauncher.cpp <span style="color: grey">(124011e)</span></li>
<li>src/start_kdeinit/CMakeLists.txt <span style="color: grey">(56a91e3)</span></li>
<li>src/start_kdeinit/start_kdeinit.c <span style="color: grey">(02d4d54)</span></li>
<li>src/start_kdeinit/start_kdeinit_wrapper.c <span style="color: grey">(f35c4a9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119711/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>