<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119377/">https://git.reviewboard.kde.org/r/119377/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Christoph Cullmann</p>
<br />
<p>On July 23rd, 2014, 3:08 p.m. UTC, Christoph Rüßler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Christoph Cullmann.</div>
<div>By Christoph Rüßler.</div>
<p style="color: grey;"><i>Updated July 23, 2014, 3:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add the commands 'reload-highlighting' and 'edit-highlighting' to the developer console.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a KF5 port of a review request I posted some weeks ago (https://git.reviewboard.kde.org/r/118616/).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The highlighting definition for the highlighting currently in use gets opened when entering the command 'edit-highlighting', and the complete set of highlighting definition gets reloaded on entering 'reload-highlighting' (takes a second or two on my machine).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I thought about a simple caching mechanism based on the mtime of the highlighting definitions, too, but it seems they only get loaded in KateSyntaxDocument::setIdentifier where there is no access to the respective KateHighlighting instance. Caching would require some kind of rewriting that code, then. If you think it’s worth it I could give it a try.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Using the two new commands on my development machine yields the desired results.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(2ec52b25dddacdbedf16b908c36fd71f11a889ae)</span></li>
<li>src/syntax/katehighlight.h <span style="color: grey">(5c34fb0c3747e72137484fa369a0804f87fb4c43)</span></li>
<li>src/syntax/katehighlight.cpp <span style="color: grey">(05b787cc9c16b2fa6c8ac82c7e809bb0ab8f5835)</span></li>
<li>src/syntax/katehighlightingcmds.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/syntax/katehighlightingcmds.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/syntax/katesyntaxmanager.h <span style="color: grey">(568154154149e7c649ec2c023c7e43d44ad07ea4)</span></li>
<li>src/syntax/katesyntaxmanager.cpp <span style="color: grey">(ebc86f3835c5bf41e01ed9d0bf7f1f2bde65ca46)</span></li>
<li>src/utils/kateglobal.cpp <span style="color: grey">(5a1cc220e8800a0e4e9203432ea5ba5f72921c21)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119377/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>