<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119388/">https://git.reviewboard.kde.org/r/119388/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119388/diff/1/?file=291491#file291491line43" style="color: black; font-weight: bold; text-decoration: underline;">templates/C++/kde-frameworks5-simple/src/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">parser</span><span class="p">.</span><span class="n">addHelpOption</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">bool KAboutData::setupCommandLine(QCommandLineParser *parser)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
{<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
if (!d->_shortDescription.isEmpty()) {<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
parser->setApplicationDescription(d->_shortDescription);<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
}</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">return</span> parser<span style="color: #666666">-></span>addOption(QCommandLineOption(QStringLiteral(<span style="color: #BA2121">"author"</span>), QCoreApplication<span style="color: #666666">::</span>translate(<span style="color: #BA2121">"KAboutData CLI"</span>, <span style="color: #BA2121">"Show author information."</span>)))
<span style="color: #666666">&&</span> parser<span style="color: #666666">-></span>addOption(QCommandLineOption(QStringLiteral(<span style="color: #BA2121">"license"</span>), QCoreApplication<span style="color: #666666">::</span>translate(<span style="color: #BA2121">"KAboutData CLI"</span>, <span style="color: #BA2121">"Show license information."</span>)));
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">}</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">setupCommandLine doesn't add addHelpOption or addVersionOption.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I tested and not added.</p></pre>
</div>
</div>
<br />
<p>- Laurent Montel</p>
<br />
<p>On juillet 21st, 2014, 4:16 après-midi UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Anne-Marie Mahfouf.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated juil. 21, 2014, 4:16 après-midi</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kapptemplate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add KDE Frameworks 5 simple app</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use kapptemplate to make the app, compile install and run</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>templates/C++/kde-frameworks5-simple/src/%{APPNAMELC}.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(726f8ad0a651aed549c0eb9c4ab3890d609b9903)</span></li>
<li>templates/C++/CMakeLists.txt <span style="color: grey">(668af487115f3a251979e3addec93c124ba81299)</span></li>
<li>templates/C++/kde-frameworks5-simple/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/icons/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/icons/hi16-apps-%{APPNAMELC}.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/icons/hi32-apps-%{APPNAMELC}.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/icons/hi48-apps-%{APPNAMELC}.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/kde-frameworks5-simple.kdevtemplate <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/kde-frameworks5-simple.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/src/%{APPNAMELC}.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/src/%{APPNAMELC}.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/src/%{APPNAMELC}.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>templates/C++/kde-frameworks5-simple/src/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119388/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>