<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119406/">https://git.reviewboard.kde.org/r/119406/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1, this escentially means that it now will use the same code as it used in 5.0, so no regressions at least.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It means though, that everything that has composeOverBorders will be rendered by the CPU rather than the GPU.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On July 22nd, 2014, 2:24 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated July 22, 2014, 2:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Always take the painter based path for composeOverBorder</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We previously only supported compose-over-border when the centre was not<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
set to tile.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A recent change to the breeze theme put everything into tiling, even if<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
some things used compose-over-border, which broke opaque widgets.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Given that creating an opacityMask loads most of the image anyway, we<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
can make use of the FrameSVG painter path and avoid any additional code<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
complexity here.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/framesvgitem.cpp <span style="color: grey">(a5fe315)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119406/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>