<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119247/">https://git.reviewboard.kde.org/r/119247/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated Iulie 13, 2014, 8:35 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here is the compiler output:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">q:\kio\src\core\udsentry.cpp(72) : error C2440: '<function-style-cast>' : cannot convert from 'const short' to 'KUser'<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
No constructor could take the source type, or constructor overload resolution was ambiguous<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
q:\kio\src\core\udsentry.cpp(73) : error C2440: '<function-style-cast>' : cannot convert from 'const short' to 'KUserGroup'<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
No constructor could take the source type, or constructor overload resolution was ambiguous<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build with msvc2013 on Windows and gcc-4.8.3 on Linux.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/udsentry.cpp <span style="color: grey">(c6ac21a1f7b45822bc3454409faf3dbdce7b2acc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119247/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>