<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119241/">https://git.reviewboard.kde.org/r/119241/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119241/diff/1/?file=289736#file289736line104" style="color: black; font-weight: bold; text-decoration: underline;">tests/ksycocatest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int main(int argc, char *argv[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">104</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KService</span><span class="o">::</span><span class="n">Ptr</span> <span class="n">service</span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="n">KService</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Ptr</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">p</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">104</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KService</span><span class="o">::</span><span class="n">Ptr</span> <span class="n">service</span><span class="p"><span class="hl">(</span></span><span class="k"><span class="hl">static_cast</span></span><span class="o"><span class="hl"><</span></span><span class="n">KService</span><span class="o"><span class="hl">*></span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">p</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">data</span></span><span class="p"><span class="hl">())</span>);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why does it need a static_cast if we're upcasting?<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Also constructing a shared pointer from the data field in another one seems dangerous...</p></pre>
</div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On July 12th, 2014, 9:41 a.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated July 12, 2014, 9:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix QExplicitlySharedDataPointer usage
One of the constructors of QExplicitlySharedDataPointer got disabled in
Qt 5.4 due to being to permissive.
Also see:
http://kfunk.org/2014/07/10/wrap-up-issues-with-qexplicitlyshareddatapointer-ksharedptr-successor/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kbuildsycoca/kbuildservicefactory.cpp <span style="color: grey">(bc36a22ced38892a92656d37a5d63e768dec6d40)</span></li>
<li>src/kbuildsycoca/kbuildservicegroupfactory.cpp <span style="color: grey">(ea0d6ed094347c4bb3f0ce2bfd9a26445a25c545)</span></li>
<li>src/kbuildsycoca/kbuildservicetypefactory.cpp <span style="color: grey">(8f577a4267e8818e7e2cf5109068659439ca3221)</span></li>
<li>src/kbuildsycoca/kbuildsycoca.cpp <span style="color: grey">(ed2929f4e60a1841807ce8490c8057d5a7b55827)</span></li>
<li>src/services/kmimetypefactory.cpp <span style="color: grey">(a52d07d1dd9040c0a79f36f1665822e714d9b369)</span></li>
<li>src/services/kservicefactory.cpp <span style="color: grey">(bb1e0f58396a358c3168c74a89be04315a295fcd)</span></li>
<li>src/services/kservicegroup.cpp <span style="color: grey">(0bda1340ae0356c3d5aca9a9f0b3dd5e905638d8)</span></li>
<li>src/services/kservicetypefactory.cpp <span style="color: grey">(7599c4c73220b2aca366f41ac5cd7d05abfa8afc)</span></li>
<li>src/sycoca/ksycocadict.cpp <span style="color: grey">(a584f933bff10f44bc257ab996aaee3ad38cc79c)</span></li>
<li>tests/ksycocatest.cpp <span style="color: grey">(d51d80a691427fa4295dd06802de2fb87112f0ff)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119241/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>