<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119249/">https://git.reviewboard.kde.org/r/119249/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please make it one commit for each issue you listed (except issue 2, of course, since that's covered in the other review request).</p></pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On July 12th, 2014, 7:15 p.m. UTC, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated July 12, 2014, 7:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here is a list of issues:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry'<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
5. KEditListBox::CustomEditor linker error caused by missing export</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build with msvc2013 on Windows and gcc-4.8.3 on Linux.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdecore/k3resolver.h <span style="color: grey">(e956c6f05e0fd821bb41dc63bc2f0933b818aafd)</span></li>
<li>src/kdemacros.h.cmake <span style="color: grey">(c406623401a5e47ecfd45fe135c9f2019f2abe04)</span></li>
<li>src/kdeui/keditlistbox.h <span style="color: grey">(e19474b3bb03587421f0afbc20346a8d359417b1)</span></li>
<li>src/kio/netaccess.h <span style="color: grey">(91f3aba055cceddf10a7c48c710356ce04d9939f)</span></li>
<li>tests/kprintpreview_test.cpp <span style="color: grey">(79cac037ab38bce89b97e4ede58eb58d821b25f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119249/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>