<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119005/">https://git.reviewboard.kde.org/r/119005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 30th, 2014, 2:31 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems wrong to me. QSettings is not a desktop file parser. It will get escaping wrong, compared to what the desktop entry spec says.
Isn't the long term solution to write .json files directly anyway?</pre>
</blockquote>
<p>On June 30th, 2014, 3:05 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, after reading the desktop file spec it seems that this doesn't make too much sense since there are some differences to INI files.
All the plugin .desktop files I looked at don't use comments (# vs ;) so nothing broke here.
However, I still think this tool should be in kcoreaddons since e.g. KPluginLoader is there. Would it make sense to write a QtCore only replacement that doesn't use kconfig or is this a waste of time?</pre>
</blockquote>
<p>On June 30th, 2014, 4:32 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After creating a test case I noticed that KDesktopFile/KConfig also doesn't quite adhere to the desktop file spec.
Lists should be separated with a semicolon and use \; to include semicolons. However, it treats e.g. "X-KDE-PluginInfo-Depends=foo;bar;escaped\;semicolon" as a single string.
KConfig uses a comma as a separator instead.
Test case: http://paste.kde.org/pzvguaf91</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The desktop entry spec mandates ';' for very specific entries (Categories, MimeTypes, etc.)
X-KDE-* is our own, we can use whatever we want for these - and we use comma.
KConfig/KDesktopFile has readXdgListEntry() for ';'-separated lists (while readEntry<QStringList> is for comma-separated lists).</pre>
<br />
<p>- David</p>
<br />
<p>On June 29th, 2014, 5:59 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Sebastian Kügler.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated June 29, 2014, 5:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It now uses QSettings to read the desktop file instead of kconfig which
means that this tool could move to kcoreaddons.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">now includes all fields (Comment + Comment[de] + Comment[...], etc)
I guess desktoptojson could be move to kcoreaddons for 5.1 and have kservice_desktop_to_json forward to a new kcoreaddons_desktop_to_json for cmake source compatibility</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/desktoptojson/CMakeLists.txt <span style="color: grey">(134dabe62ca051eea26631aedc72b108e1b60444)</span></li>
<li>src/desktoptojson/kconfigtojson.cpp <span style="color: grey">(5c0d751f05503e471ed9c49efc51bfdd22774be9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119005/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>