<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119043/">https://git.reviewboard.kde.org/r/119043/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 1st, 2014, 1:43 a.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119043/diff/4/?file=285778#file285778line24" style="color: black; font-weight: bold; text-decoration: underline;">core/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set_target_properties</span><span class="p">(</span><span class="o">${</span><span class="nv">POLKITQT-1_CORE_PCNAME</span><span class="o">}</span> <span class="s">PROPERTIES</span> <span class="s">VERSION</span> <span class="o">${</span><span class="nv">POLKITQT-1_LIBRARY_VERSION</span><span class="o">}</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set_target_properties</span><span class="p">(</span><span class="o">${</span><span class="nv">POLKITQT-1_CORE_PCNAME</span><span class="o">}</span> <span class="s">PROPERTIES</span> <span class="s">VERSION</span> <span class="o">${</span><span class="nv">POLKITQT-1_LIBRARY_VERSION</span><span class="o">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe we want to set an EXPORT_NAME? This way the user won't need a variable to link to the library.
It's better linking against libraries rather than variables because you don't risk adding a typo and resolving to an empty string.</pre>
</blockquote>
<p>On July 1st, 2014, 6:37 p.m. CEST, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we have export just a few lines below, so you can link to PolkitQt5-1::polkit-qt5-core-1... or i completely missed your point?
other issues, to me looks could be droped? will re-add quotes to POLKITQT-1_VERSION_STRING. for the rest: as this is still both Qt4 and Qt5 library in the same branch, i would really like to avoid not needed changes. That can be done once Qt4 support is gone/moved to branch.</pre>
</blockquote>
<p>On July 1st, 2014, 6:42 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I don't think any healthy person would want to type anything like "PolkitQt5-1::polkit-qt5-core-1", at least PolkitQt5-1::Core.
That won't mean changes on currently running applications because these should be using the variable anyway.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">right. will update soon™</pre>
<br />
<p>- Hrvoje</p>
<br />
<p>On June 30th, 2014, 11:53 p.m. CEST, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and Christophe Giboudeaux.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated June 30, 2014, 11:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
polkit-qt-1
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">added exported targets, simplify main CMakeLists...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds, cmake files visually inspected, seem fine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(021bf88)</span></li>
<li>PolkitQt-1Config.cmake.in <span style="color: grey">(8b722a6)</span></li>
<li>agent/CMakeLists.txt <span style="color: grey">(f1ba438)</span></li>
<li>core/CMakeLists.txt <span style="color: grey">(e9b3ebb)</span></li>
<li>gui/CMakeLists.txt <span style="color: grey">(10b06ae)</span></li>
<li>polkit-qt-1.pc.cmake <span style="color: grey">(2f33204)</span></li>
<li>polkit-qt-agent-1.pc.cmake <span style="color: grey">(6ccc6dd)</span></li>
<li>polkit-qt-core-1.pc.cmake <span style="color: grey">(a9e0750)</span></li>
<li>polkit-qt-gui-1.pc.cmake <span style="color: grey">(6b9c2cf)</span></li>
<li>polkit-qt5-1.pc.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>polkit-qt5-agent-1.pc.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>polkit-qt5-core-1.pc.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>polkit-qt5-gui-1.pc.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119043/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>