<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119053/">https://git.reviewboard.kde.org/r/119053/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma and David Faure.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 1, 2014, 8:37 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for the last minute changes. I expected the bugs to be in the KCM and not in kglobalaccel and unfortunately the autotests cannot be executed on build.kde.org thus I never noticed that they don't pass :-(
Update actionShortcuts on auto loading shortcuts
When using auto-loading the shortcut needs to be updated from what the
daemon returns. This had not been done yet and KGlobalAccel still kept
the shortcut passed in.
With this change the autotests pass and the global shortcut KCM shows
the used shortcuts properly.
Update actionShortcuts when daemon emits yourShortcutGotChanged
Without updating the shortcut kept in actionShortcuts KGlobalAccel
still returns the old shortcut when invoking the shortcut() method.
The unit test for this was unfortunately broken as it checked the
wrong QAction. This is also fixed with this change.
Set componentName and DisplayName on QActions in KGlobalShortcutTest
This fixes the testFindActionByKey.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unit tests pass now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kglobalshortcuttest.cpp <span style="color: grey">(3f76760cb9e06a19d636a81546706cee548e1869)</span></li>
<li>src/kglobalaccel.cpp <span style="color: grey">(a98891c806764132b4f02b828d59584a85745fb3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119053/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>