<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118970/">https://git.reviewboard.kde.org/r/118970/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't find any large problems in the patch itself, just a few small questions (see below).
One thing to consider, though, is if the base for this patch is too old. After a hiatus, new things have been added to libkdeedu in master and some of those are important. Perhaps it is time to rebase the branch on the current master before going further?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118970/diff/2/?file=284914#file284914line53" style="color: black; font-weight: bold; text-decoration: underline;">keduvocdocument/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::KDE4Support</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"><span class="hl">#</span> KF5::KDE4Support</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why removed in other places and commented out here?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118970/diff/2/?file=284919#file284919line253" style="color: black; font-weight: bold; text-decoration: underline;">keduvocdocument/keduvocdocument.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int KEduVocDocument::open( const QUrl& url )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">252</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q<span class="hl">String</span></span><span class="hl"> </span><span class="n"><span class="hl">t</span>emporaryFile</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">253</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q<span class="hl">T</span>emporaryFile</span><span class="hl"> </span><span class="n"><span class="hl">tempFile</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't say this is wrong. I just want to point out that there are some interesting new features in master that this must work together with. One of those things is file locking which I can imagine could clash with this.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118970/diff/2/?file=284929#file284929line42" style="color: black; font-weight: bold; text-decoration: underline;">keduvocdocument/tests/converter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">K4AboutData</span> <span class="n">about</span><span class="p">(</span> <span class="s">"kvtml-converter"</span><span class="p">,</span> <span class="mi">0</span><span class="p">,</span> <span class="n">ki18n</span><span class="p">(</span> <span class="s">"Kvtml-Converter"</span> <span class="p">),</span> <span class="s">"0.1"</span><span class="p">,</span> <span class="n">ki18n</span><span class="p">(</span> <span class="s">"kvtml file converter"</span> <span class="p">),</span> <span class="n">K4AboutData</span><span class="o">::</span><span class="n">License_GPL</span><span class="p">,</span> <span class="n">ki18n</span><span class="p">(</span> <span class="s">"© 2007 Jeremy Whiting"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QCoreApplication</span><span class="o">::</span><span class="n">setApplicationName</span><span class="p">(</span><span class="s">"kvtml-converter"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, the file name says .../tests/converter. Is this a test or a converter?</pre>
</div>
<br />
<p>- Inge Wallin</p>
<br />
<p>On June 27th, 2014, 4:55 a.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu, KDE Frameworks, Aleix Pol Gonzalez, and Inge Wallin.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated June 27, 2014, 4:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkdeedu
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port tests away from KCmdLineArgs to QCommandLineParser.
Port from KDE_DEPRECATED to KEDUVOCDOCUMENT_DEPRECATED (Maybe we should remove these?)
Port from KLocale to klocalizedstring.h</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It still builds and the tests run.
Unrelated the sharedkvtmlfilestest exposes a bug in KEduVocDocument::open where the KFilterDev wont open, (bug from previous commit) not sure what to do here to fix it though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4feb10b67f78530170aaae216b9347cf94c0e51a)</span></li>
<li>keduvocdocument/CMakeLists.txt <span style="color: grey">(c242c46fa79f128d63ccdeb5c4f611ad7294c874)</span></li>
<li>keduvocdocument/keduvocarticle.h <span style="color: grey">(b0b69c06d3d91ecc1680ecb18c9dd074beed1cb1)</span></li>
<li>keduvocdocument/keduvoccsvreader.cpp <span style="color: grey">(e3d471c4ecbb1236bae73714f27e357a1681ec70)</span></li>
<li>keduvocdocument/keduvoccsvwriter.cpp <span style="color: grey">(32172e47d3617c082378969735dbd23d3178f06e)</span></li>
<li>keduvocdocument/keduvocdocument.h <span style="color: grey">(9da14c62c84a07ffc53ef46f4c48e35824210d2c)</span></li>
<li>keduvocdocument/keduvocdocument.cpp <span style="color: grey">(7026ccb9046968821b11ce6e07276d81e58e41c6)</span></li>
<li>keduvocdocument/keduvockvtml2reader.cpp <span style="color: grey">(3884724422c318e34a5b8efc5e05481e27f7c6bc)</span></li>
<li>keduvocdocument/keduvockvtmlcompability.cpp <span style="color: grey">(e486729054a9e69fd52c4e4f1031a0bdbb3433cf)</span></li>
<li>keduvocdocument/keduvocpaukerreader.cpp <span style="color: grey">(4ded3e480222ea9401b8cbfddad2b99ba82036fb)</span></li>
<li>keduvocdocument/keduvoctranslation.h <span style="color: grey">(c41d293755f0df7f87a41300569b093d020beb06)</span></li>
<li>keduvocdocument/keduvocvokabelnreader.cpp <span style="color: grey">(ffbd64d3cd50e519af319d6d52a1491a7ed1588a)</span></li>
<li>keduvocdocument/keduvocwqlreader.cpp <span style="color: grey">(0841b1054ec41b93f4fffb1165c2c0d51806aeae)</span></li>
<li>keduvocdocument/keduvocxdxfreader.cpp <span style="color: grey">(4317f6ff1fbc8a4a19c2bbcc72af2ace295743b6)</span></li>
<li>keduvocdocument/sharedkvtmlfiles.cpp <span style="color: grey">(9f74aa2af2f69f25fca8efa1585b8c8ea1127cd9)</span></li>
<li>keduvocdocument/tests/CMakeLists.txt <span style="color: grey">(ac01a2b4a3e3b925517b2f004feb93bf365344a7)</span></li>
<li>keduvocdocument/tests/converter.cpp <span style="color: grey">(1916b2269a88e932beb46f165e6cebebcefecb3c)</span></li>
<li>keduvocdocument/tests/sharedkvtmlfilestest.cpp <span style="color: grey">(489dad4fcafa0a97fe4e93905206fb0fc53e0cf5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118970/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>