<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118928/">https://git.reviewboard.kde.org/r/118928/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, kwin and David Edmundson.</div>
<div>By Martin Gräßlin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support for showing window menu in NETRootInfo
This implements the non-standard _GTK_SHOW_WINDOW_MENU which will be
used by GTK's client-side-decoration (CSD) to show the window menu. I'm
neither happy with implementing a GTK specific hint nor am I happy
with adding any support for the completely broken GTK CSD [1] in our
source base. Outside GNOME Shell GTK should not use their CSD or at
least check whether the window manager supports CSD. Unfortunately
GTK is not doing that and leaves the windows in a rather broken state
on our side. For example the shadows are part of the windows breaking
any window snapping, moving and window activation. By implementing this
extension to show the window menu we can make the life for our users
a little bit better. It allows to show our KWin user actions menu
instead a broken GTK menu [2]. Especially it allows our users to add
sane window decorations back to the window.
Adding support for a GTK specific hint is a one time exception. We
need to add it now otherwise we cannot add the required virtual method
to NETRootInfo. I do hope that GTK tries to bring this to NETWM before
we release 5.0. Even after 5.0 I'm going to replace it by the NETWM
hint as soon as it gets standardized and thus breaking support for the
GTK hint.
[1] https://bugzilla.gnome.org/show_bug.cgi?id=729721
[2] https://bugzilla.gnome.org/show_bug.cgi?id=729788</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/netrootinfotestwm.cpp <span style="color: grey">(f8c28be51e5a5b19d436c54eede0e8659a65c84e)</span></li>
<li>src/netwm.h <span style="color: grey">(2d812a755565a09b2850958a014060a864a652a0)</span></li>
<li>src/netwm.cpp <span style="color: grey">(1daad1e5fc87fa85da6348a059d0ae0acec26eaf)</span></li>
<li>src/netwm_def.h <span style="color: grey">(0edadc085e08531ec81bcde5651e8475e8573091)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118928/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>