<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118853/">https://git.reviewboard.kde.org/r/118853/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 21st, 2014, 11:36 a.m. CEST, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What is the status of categorized debugging/logging support in Qt, and how do we utilize that in our frameworks?
If we are still simply using uncategorized qDebug(), please commit it.</pre>
</blockquote>
<p>On June 21st, 2014, 2:37 p.m. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We can use qCDebug; the only problem is that right now (for what I know) categories can't be enabled/disabled dynamically, but statically from the code. See:
http://community.kde.org/Frameworks/Porting_To_qCDebug</pre>
</blockquote>
<p>On June 23rd, 2014, 10:43 p.m. CEST, <b>Elias Probst</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"In Qt 5.3 this should not be needed for KDE anymore because we should then be able to manage the logging categories from outside your application."
So this means just this would be enough?
qCDebug() << "my debug message";
How will the result then look like? Will it be categorized based on the application using KF5 kiconloader? Or will kiconloader need its own logging category?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please check the section "Actual porting: kDebug to qCDebug" of the page I mentioned above, it provides an example (qCDebug needs a category).</pre>
<br />
<p>- Luigi</p>
<br />
<p>On June 21st, 2014, 4:53 a.m. CEST, Elias Probst wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Elias Probst.</div>
<p style="color: grey;"><i>Updated June 21, 2014, 4:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently I get to see this debug log message quite often:
Warning: could not find "unknown" icon for size 48
This makes it hard to find out which icon was originally requested.
This patch adds a debug log message including the name + size of the not found icon before attempting to load the "unknown" icon.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Debug log messages look now like this:
Icon "konsole" for size 48 not found
Warning: could not find "unknown" icon for size 48</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kiconloader.cpp <span style="color: grey">(6e22f3e864db190f409550fcac964154c895ca6b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118853/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>