<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118909/">https://git.reviewboard.kde.org/r/118909/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, kwin and Eike Hein.</div>
<div>By Martin Gräßlin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Imply SkipTaskbar and SkipPager depending on Window Type
Quoting EWMH:
"Applications should not set this hint if _NET_WM_WINDOW_TYPE already
conveys the exact nature of the window."
This means if the window type implies a SkipPager or SkipTaskbar the
window will not have it set. To simplify the life of our API users we
should add the state and not require our users to check that manually.
Every Normal or Dialog window does not imply that it shouldn't be shown.
As our KDE Override is not a proper window type we can assume that it's
also a Normal window or a Dialog.
The change is done in KWindowInfo and requires that the API user adds
NET::WMWindowType explicitly to the properties. NETWinInfo is not
adjusted to have it reflect the actual state of the atoms. Here we can
assume that the users of the more low-level API are aware of the EWMH
spec and will implement these checks themselves.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kwindowinfox11test.cpp <span style="color: grey">(50ce806add5ea8f6cb19e537609e936c3d0275bd)</span></li>
<li>src/kwindowinfo.h <span style="color: grey">(e9b7a0af66a1e0e0c4e4b84496157dd53035abc8)</span></li>
<li>src/kwindowinfo_x11.cpp <span style="color: grey">(87a887c7e068f71cffc58c184bcd4b4722564047)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118909/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>