<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114283/">https://git.reviewboard.kde.org/r/114283/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 3rd, 2013, 8:49 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation (which I really hope we'll be able to).
I'd also like to read Marco's opinion on this.</pre>
</blockquote>
<p>On December 3rd, 2013, 8:55 p.m. UTC, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have you heard of QML Plugin versions? The import line with a version behind it.
You can safely remove what you want and just give it a new version number.</pre>
</blockquote>
<p>On December 3rd, 2013, 9:10 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To me in general is a good idea and is fine as long as the api stays the same (eventually adding missing properties back if any)</pre>
</blockquote>
<p>On December 3rd, 2013, 9:12 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">on this in particular, ScrollBar.qml was public api, so shouldn't be removed, even if not used by this component in partibular.
apart from that is good to go.</pre>
</blockquote>
<p>On June 19th, 2014, 3:44 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any news on this? Plasma-NM has recently switched over to a QtQuick Controls ScrollView, and so did I.</pre>
</blockquote>
<p>On June 19th, 2014, 5:06 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">eeew, and does use a correct scrollbar?</pre>
</blockquote>
<p>On June 19th, 2014, 5:08 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, it is not. It's the wrong colour and width.</pre>
</blockquote>
<p>On June 19th, 2014, 5:12 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you're using the Breeze QtCurve theme you can hardly tell a difference hence I changed it too. Then I tried it with Oxygen and it looked bad. But at least that thing is reliable and doesn't bounce around.</pre>
</blockquote>
<p>On June 19th, 2014, 5:19 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it should never be assumed that a particular theme is used. (and i think this patch should be pushed and be reverted to use this component)
what does "bounce around" mean btw?</pre>
</blockquote>
<p>On June 19th, 2014, 5:45 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indeed.
Bounce around meaning behaving like the Widgets Explorer - erratic mousewheel scroll behavior, bouncing off the edge when reaching end of list, list can be dragged around with mouse, etc</pre>
</blockquote>
<p>On June 19th, 2014, 5:54 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that's just default settings on the boundsbehavior, if is just that is easy fix</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The big thing I've seen which is problematic is removing the first visible entry in a ListView.
Instead of adjusting the contentY like any sane programmer would do, ListView "optimises" by adjusting the originY to be non-zero.
The current scrollbar doesn't expect Flickable to be weird and then gets in a mess showing a large empty white space on top. </pre>
<br />
<p>- David</p>
<br />
<p>On June 19th, 2014, 6 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated June 19, 2014, 6 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use QtQuickControls ScrollView internally
Flickable has a very odd API in which contentHeight can't be trusted. we need to update our ScrollBars/ScrollArea to make use of the new
originX and originY in order to fix a lot of bugs that we currently see with scrollbars.
Instead of doing that, by porting to use QtQuick Controls we get all
these bug fixes as well as _significantly_ reducing our code.
Having a separate logic vs UI, makes things (IMHO) easier to read.
I don't expect to merge this as-is; I haven't included the plasma
feature that creates a SectionScroller if the content is a listview, but
that should be viable. As far as I know all other features (keyboard
controls / hiding buttons on touch screens) are still kept.
Files removed are as indication as to long term changes from making this
change, in order to do that we need to port all users from ScrollBars ->
ScrollArea. (which is worth doing anyway IMHO)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Widget Explorer in plasma-shell looks exactly as before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml <span style="color: grey">(860c0e7)</span></li>
<li>src/declarativeimports/plasmaextracomponents/qml/styles/ScrollViewStyle.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114283/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>