<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118264/">https://git.reviewboard.kde.org/r/118264/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 28th, 2014, 2:56 p.m. CEST, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8) fails with this error:
[ 55%] Building CXX object autotests/CMakeFiles/KAuthHelperTest.dir/HelperTest.cpp.o
In file included from /home/aurelien/build/kf5/frameworks/kauth/src/moc_Polkit1Backend.cpp:9:0,
from /home/aurelien/build/kf5/frameworks/kauth/src/kauth_backend_plugin_automoc.cpp:3:
/home/aurelien/build/kf5/frameworks/kauth/src/../../../../../src/kf5/frameworks/kauth/src/backends/polkit-1/Polkit1Backend.h:31:31: fatal error: PolkitQt1/Authority: No such file or directory
#include <PolkitQt1/Authority>
^
compilation terminated.
In file included from /home/aurelien/src/kf5/frameworks/kauth/src/backends/polkit-1/Polkit1Backend.cpp:22:0:
/home/aurelien/src/kf5/frameworks/kauth/src/backends/polkit-1/Polkit1Backend.h:31:31: fatal error: PolkitQt1/Authority: No such file or directory
#include <PolkitQt1/Authority>
^
compilation terminated.</pre>
</blockquote>
<p>On May 28th, 2014, 4:01 p.m. CEST, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8) fails with this error:
you're right. bac771e in polkit-qt-1 broke it. i've tested with official tarball + commit ddca404 ('Add Qt 5 support').
with polkit-qt-1 buildsystem that commit seems wrong. Kevin, can you tell what was reasoning for the change?</pre>
</blockquote>
<p>On June 17th, 2014, 6:05 p.m. CEST, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I did that commit, @INCLUDE_INSTALL_DIR@ and @LIB_INSTALL_DIR@ were absolute path. Might have changed in the meantime of course.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">with that commit, and without passing neither INCLUDE_INSTALL_DIR or LIB_INSTALL_DIR, one gets:
set(POLKITQT-1_INCLUDE_DIR "include/polkit-qt5-1")
...
set(POLKITQT-1_LIB_DIR "lib64")
so, the commit fixes the vars when they are absolute, but breaks when relative paths are used, and when no special path is used.
just to note - it was like this before, the 'Qt5 port patch' temporary 'fixed' it for the above two cases.
i guess it needs more bulletproof solution.</pre>
<br />
<p>- Hrvoje</p>
<br />
<p>On May 28th, 2014, 4:01 p.m. CEST, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 4:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kauth
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">since now master of polkit-qt-1 is able to exist w/o issues with Qt4 variant, KAuth should switch to that, instead of building either w/ no backend, or with the branch...
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Got CMake message:
Building PolkitQt5-1 KAuth backend
and kauth-policy-gen also built
KAuth macros generate correct polkit-1 rules (e.g. date kcm in plasma-desktop, etc)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/KF5AuthMacros.cmake <span style="color: grey">(4cdf3ab)</span></li>
<li>src/ConfigureChecks.cmake <span style="color: grey">(aff05ed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118264/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>