<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118612/">https://git.reviewboard.kde.org/r/118612/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit a0c1b1c2b263bc7d0ed2f71028231ca261ab5c33 by Matthew Dawson to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 13th, 2014, 9:57 p.m. UTC, Matthew Dawson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Matthew Dawson.</div>
<p style="color: grey;"><i>Updated June 13, 2014, 9:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When using QFileSystemWatcher, try to avoid having deleted files stop being watched.
When a file is deleted, QFileSystemWatcher does not explicitly signal this fact,
instead emitting a generic changed signal. However, it will stop watching the file
in question, at least on Linux with the inotify backend. Normally this is ok, but
if a file is quickly recreated and the inode number is unchanged, KDirWatch assumes
the file is still monitored and no further changes to the file will occur.
Instead, KDirWatch will now always try to re-add the file to QFileSystemWatcher.
It doesn't bother checking if the operation succeeded, as in most cases it will
fail as the file is still watched. It can only assume the file is now being
watched at this point.
Fix unit tests for KDirWatch when TMPDIR's filesystem reuses inode numbers.
When the filesystem TMPDIR points to (by default /tmp) reuses inode numbers,
the testDeleteAndRecreateFile test will fail as neither the stat nor the
QFileSystemWatcher backends can detect the deletion/recreation as two discrete
events. They only detect the fact the file changed, and emit the dirty signal.
Fix the test suite to check for this case, and allow the test to proceed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests all pass on all four backends (FAM only tested against gamin)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kdirwatch_unittest.cpp <span style="color: grey">(c3dba4391b8ebcbedeaa53d51f2a170aa5695ccb)</span></li>
<li>src/lib/io/kdirwatch.cpp <span style="color: grey">(7da1fdba8cd1a2e6a7d5bf9cef999d50b44ebf99)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118612/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>