<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118716/">https://git.reviewboard.kde.org/r/118716/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 13th, 2014, 11:49 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118716/diff/1/?file=280670#file280670line13" style="color: black; font-weight: bold; text-decoration: underline;">kcms/translations/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::KDELibs4Support</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">new code shouldn't use kdelibs4support</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There doesn't seem to be an equivalent for translation changed. I'll just drop it then, since we ask the user to re-login, anyway.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On June 13th, 2014, 2:31 a.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma, Chusslove Illich, and John Layt.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated June 13, 2014, 2:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the second part of the replacement of the Locale KCM: Translations.
This KCM complements the formats KCM, which sets the locale. With this KCM, the user can configure GUI translations.
The mechanism to set up the langhere, KF5-uage is the same as in the formats KCM, while formats set LC_* and LANG, this KCM will set LANGUAGE. The UI is roughly the same as in the previous "Locale", though here, KF5-compatible mechanism (QLocale, ki18n, are used.
This code has been written by John Layt, I've merely cleaned it up a bit, added some missing features, tested it and am submitting it now for review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Set up languages (x-test, others), re-logged in, languages correctly set up for KF5 and console applications.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/CMakeLists.txt <span style="color: grey">(6bda5434d7d1147c0e8295f2919c17ea59d1be99)</span></li>
<li>kcms/formats/kcmformats.h <span style="color: grey">(345fbb193d327c39fd80d690bdf8f41d3171c6a2)</span></li>
<li>kcms/formats/kcmformats.cpp <span style="color: grey">(4169244f68b4f3c766cae514a8dde4d902cbfee1)</span></li>
<li>kcms/formats/writeexports.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/translations/CMakeLists.txt <span style="color: grey">(dd70f47d11e2f3a1359cae2a1306b217af82d848)</span></li>
<li>kcms/translations/Messages.sh <span style="color: grey">(38f48cb32af5ff278bb25b6bef323c546e9223a3)</span></li>
<li>kcms/translations/kcmtranslations.h <span style="color: grey">(adc3a48d1b65cbba89d74326eb42c7925a3708b2)</span></li>
<li>kcms/translations/kcmtranslations.cpp <span style="color: grey">(9095fda40ed5c794f06c56ed842bf7861dc88f2e)</span></li>
<li>kcms/translations/kcmtranslationswidget.ui <span style="color: grey">(4ad3242811d3f92acc05d010e120189f681446ad)</span></li>
<li>kcms/translations/translations.desktop <span style="color: grey">(ea9086732f7359ba58496d8b60851eca34669c16)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118716/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/28a00558-f671-4f39-bfe3-ca9dca8e98ce__tranlationskcm.png">KCM in systemsettings</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>