<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118666/">https://git.reviewboard.kde.org/r/118666/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118666/diff/1/?file=280266#file280266line205" style="color: black; font-weight: bold; text-decoration: underline;">src/core/kconfiggroup.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static QList<qreal> asRealList(const QByteArray &string)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">205</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">QString</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLatin1</span></span><span class="p">(</span><span class="s">"</span><span class="se">\"</span><span class="s">%1</span><span class="se">\"</span><span class="s"> - conversion of </span><span class="se">\"</span><span class="s">%3</span><span class="se">\"</span><span class="s"> to %2 failed"</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">205</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">QString<span class="hl">Literal</span></span><span class="p">(</span><span class="s">"</span><span class="se">\"</span><span class="s">%1</span><span class="se">\"</span><span class="s"> - conversion of </span><span class="se">\"</span><span class="s">%3</span><span class="se">\"</span><span class="s"> to %2 failed"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shouldn't this be translated?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118666/diff/1/?file=280274#file280274line209" style="color: black; font-weight: bold; text-decoration: underline;">src/kconf_update/kconf_update.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KonfUpdate::logFileError()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">208</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">Q_FOREACH</span></span> <span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">d<span class="hl">ir</span></span><span class="p">,</span> <span class="n">dirs</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">204</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">foreach</span></span> <span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">d</span><span class="p">,</span> <span class="n">dirs</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why do you change Q_FOREACH to foreach?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118666/diff/1/?file=280274#file280274line275" style="color: black; font-weight: bold; text-decoration: underline;">src/kconf_update/kconf_update.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KonfUpdate::checkGotFile(const QString &_file, const QString &id)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">272</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KConfig</span><span class="hl"> </span><span class="n"><span class="hl">cf</span>g</span><span class="p">(</span><span class="n">file</span><span class="p">,</span> <span class="n">KConfig</span><span class="o">::</span><span class="n">SimpleConfig</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">270</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KConfig<span class="hl">Group</span></span><span class="hl"> </span><span class="n"><span class="hl">cg</span></span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="n"><span class="hl">KConfi</span>g</span><span class="p">(</span><span class="n">file</span><span class="p">,</span> <span class="n">KConfig</span><span class="o">::</span><span class="n">SimpleConfig</span><span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">group</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"$Version"</span></span><span class="p"><span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doesn't that make the KConfig go out of scope too early?
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118666/diff/1/?file=280275#file280275line36" style="color: black; font-weight: bold; text-decoration: underline;">src/kconf_update/kconfigutils.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace KConfigUtils</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">36</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">KConfigGroup</span> <span class="n">openGroup</span><span class="p">(</span><span class="n">KConfig</span> <span class="o">*</span><span class="n">config</span><span class="p">,</span> <span class="k">const</span> <span class="n">QStringList</span> <span class="o">&</span><span class="n"><span class="hl">_</span>lst</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">36</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">KConfigGroup</span> <span class="n">openGroup</span><span class="p">(</span><span class="n">KConfig</span> <span class="o">*</span><span class="n">config</span><span class="p">,</span> <span class="k">const</span> <span class="n">QStringList</span> <span class="o">&</span><span class="n">lst</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This modifies the actual semantic of the function, although it might still be correct.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118666/diff/1/?file=280275#file280275line38" style="color: black; font-weight: bold; text-decoration: underline;">src/kconf_update/kconfigutils.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace KConfigUtils</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">_lst</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KConfigGroup</span> <span class="n">cg</span> <span class="o">=</span> <span class="n">config</span><span class="o">-></span><span class="n">group</span><span class="p">(</span><span class="s">""</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"" -> QString()</pre>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On June 11th, 2014, 1:59 p.m. UTC, Thomas Braxton wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By Thomas Braxton.</div>
<p style="color: grey;"><i>Updated June 11, 2014, 1:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simple Cleanups
- use Q_NULLPTR instead of 0 or NULL
- simplify some foreach loops
- use QStringLiteral in a few places
- added a few consts</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All tests still pass</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kconfigloadertest.cpp <span style="color: grey">(451d636e4e584a97d897634b1db1459b47e12355)</span></li>
<li>src/core/kconfig.h <span style="color: grey">(d27eebe7c41cb433b1808882c53cbf7b4c870950)</span></li>
<li>src/core/kconfig.cpp <span style="color: grey">(ea9746c001e235529a1cdd5865b9e1b5c129b56a)</span></li>
<li>src/core/kconfigbackend.cpp <span style="color: grey">(90655facb49ebb1702fa1635ae5db3fc11fc31a3)</span></li>
<li>src/core/kconfigdata.h <span style="color: grey">(e57becb24936865d009a700892893049b3e079f1)</span></li>
<li>src/core/kconfiggroup.h <span style="color: grey">(3c4bce8433e3c5d4cb2d9fdd111a43f04cf3c295)</span></li>
<li>src/core/kconfiggroup.cpp <span style="color: grey">(6f609baefec5beaf38fdfedd6d192b395e3f8acb)</span></li>
<li>src/core/kconfigini.cpp <span style="color: grey">(df834f57fc44bbf9f4f28f1bc4eb5717e2ff1cee)</span></li>
<li>src/core/kcoreconfigskeleton.h <span style="color: grey">(bb9c1cf936b87e2456726a2bb3428be42558b39f)</span></li>
<li>src/gui/kconfiggroupgui.cpp <span style="color: grey">(a14c204c143b38189f042c37ccbe1bf6355a2a18)</span></li>
<li>src/gui/kconfiggui.cpp <span style="color: grey">(1eee8ce50fd660f11cad53c2a493072317e1f331)</span></li>
<li>src/gui/kconfigloader.h <span style="color: grey">(36eb182fbf1c241a043566a13d7c6c123a6e455f)</span></li>
<li>src/gui/kconfigloader.cpp <span style="color: grey">(1dd9e7fc44a367165fedc2e7760c8b524ecd210e)</span></li>
<li>src/gui/kconfigskeleton.h <span style="color: grey">(f87eef6e5268a3b4e93fd733f70a2bdd4c4be753)</span></li>
<li>src/kconf_update/kconf_update.cpp <span style="color: grey">(829d35e61da3d303539044d0dc652cc99dec35a2)</span></li>
<li>src/kconf_update/kconfigutils.cpp <span style="color: grey">(f2663e1316ec2cdbef303385787d14406e02f4a1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>