<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118603/">https://git.reviewboard.kde.org/r/118603/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Kevin Ottens, Michael Pyne, and Stephen Kelly.</div>
<div>By David Faure.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove data race on boolean by removing qRegisterMetaType call altogether.
Apparently the Q_DECLARE_METATYPE macro is enough to get rid of this runtime warning:
QWARN: KJobTest::testProgressTracking() QSignalSpy::initArgs: Don't know how to handle 'KJob::Unit', use qRegisterMetaType to register it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This showed up in the first place when starting to write a threaded unittest for kiocore. The first race was on KJobPrivate::_k_kjobUnitEnumRegistered.
I tested that qRegisterMetaType isn't actually necessary anymore in Qt5, using kjobtest, as shown in commit log.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/jobs/kjob.h <span style="color: grey">(fb7de853fc306ea938d19aba2729ff7713f9b7bb)</span></li>
<li>src/lib/jobs/kjob.cpp <span style="color: grey">(33d894ad7233921dee77ab9d403016421a04978d)</span></li>
<li>src/lib/jobs/kjob_p.h <span style="color: grey">(c11a4d8ea8f4380ec8bc4da1cd88e1053042c691)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118603/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>