<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118538/">https://git.reviewboard.kde.org/r/118538/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 4th, 2014, 7:30 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what is a valid use case where qml needs to know where the dialog actually is?(not hypothetical please)
doing the animation on the proper direction can be tracked completely internally
also, plasmoids should never ever do a screen edge animation when in the middle of the desktop, the animation looks bad where it's clipped if it's not against a panel or a screen edge</pre>
</blockquote>
<p>On June 4th, 2014, 8:35 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Milou places the most relevant item closest to the launcher.
</pre>
</blockquote>
<p>On June 4th, 2014, 9:15 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, it would be relevant only in the case milou is iconified and in the desktop, that seems quite a narrow case.
api wise it may make sense a Plasma::Types::Direction visualParentDirection, *but* it would have to be exported in plasmoid as well, and I don't want anything like that here.
API that is added ad hoc for a single, extremely narrow use case is never a good idea.</pre>
</blockquote>
<p>On June 4th, 2014, 10:32 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kickoff changes direction too so the toolbar is closest to the launcher.
However, I'm not too fussed about the new property, I can remove the Q_PROPERTY and add it if we decide it's needed. The important part for me is making it show the correct borders and animate in the right direction.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think animating or borders is a problem, because the location dependent borders should be disabled only when at screen edges, when the location is the real one, and the animation as well should be done only when at screen edge or in panel as well.
If the property ends up being really needed, i can see it working as a direction (instead of location enum), without any setter.
To be usable in applets however, it would still need a plasmoid property, like popupsDirection, wouldn't even be that bad, but for it to work it would need to track the scene position of the applet, thing that seems possible in 5.3 but heavy on cpu</pre>
<br />
<p>- Marco</p>
<br />
<p>On June 4th, 2014, 10:43 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated June 4, 2014, 10:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a property containing the real edge a dialog is shown on.
If a dialog is meant to be shown on the left of an item, if there is not
enough space it will be shown on the right.
We need to keep track of where we're actually shown in order to show the
correct borders and perform the animation in the correct direction.
It is exposed as a property in case the dialog itself needs to know
which side of the parent item it is, for example if needs to show an
arrow to the parent.
--
Fixed some serious copy + paste fails in the hitting the bottom edge of
the screen check.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran dialog_positioning.qml in all 8 combinations of edges + preferred locations.
(i.e placed near left edge, showed item with location set to both left and right)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/dialog.cpp <span style="color: grey">(2f8227c)</span></li>
<li>src/plasmaquick/dialog.h <span style="color: grey">(4009222)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118538/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>