<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118499/">https://git.reviewboard.kde.org/r/118499/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Alex Merry.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khtml
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Put kparts into a kf5/parts subdirectory of the plugins dir</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built, installed, ran tests. The partviewer in the tests/ directory of KParts successfully loads khtml when you point it at a HTML file. I can't get it to load any of the other parts, though, with or without this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(8a64eace8a579e8a588fcb08e193ce26c463bd68)</span></li>
<li>src/java/CMakeLists.txt <span style="color: grey">(9ff8cdf6ac3b168a83e46db62638119ac011de83)</span></li>
<li>src/java/kjavaappletviewer.desktop <span style="color: grey">(7c3e7fa8bc484659ae7946fcc584c58cad82d47f)</span></li>
<li>src/khtml.desktop <span style="color: grey">(f8596232692a6eba1052527e169305771e72cc5a)</span></li>
<li>src/khtmladaptorpart.desktop <span style="color: grey">(fc5587e683a07baf03b2913612d558b8e11c163c)</span></li>
<li>src/khtmlimage.desktop <span style="color: grey">(5bdd5b1e0070b439cfbaa7dd4ec8a18a917f54b6)</span></li>
<li>src/kmultipart/CMakeLists.txt <span style="color: grey">(40f5051b6d76615e939d35bedd2ebd37f2bf337f)</span></li>
<li>src/kmultipart/kmultipart.desktop <span style="color: grey">(6bc38afb9b6bca4d9792c0ecdcf6697a1976e1e7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118499/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>