<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118472/">https://git.reviewboard.kde.org/r/118472/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9a3a223f40798985809d40c93edeca2519f357f4 by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 2nd, 2014, 4:04 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated June 2, 2014, 4:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Version the kded module files
This puts KIO's KDED modules in a kf5/kded subdirectory of the plugin
directory.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All the modules are properly loaded on demand when attempting to access their D-Bus interface.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/http/kcookiejar/CMakeLists.txt <span style="color: grey">(48c2df8748b6587cd5b09ee9c73c098856fdd03c)</span></li>
<li>src/ioslaves/http/kcookiejar/kcookiejar.desktop <span style="color: grey">(f5cc5f3baf6d865c6ee4b7e1b13b9967faed2413)</span></li>
<li>src/kpac/CMakeLists.txt <span style="color: grey">(a7502dc6343aeedec5c43f12ae8b222e9beba256)</span></li>
<li>src/kpac/proxyscout.desktop <span style="color: grey">(ada3db6a5e066012afb284503924d08596ba796c)</span></li>
<li>src/kpasswdserver/CMakeLists.txt <span style="color: grey">(c49d056e91c64f2450cf150458a69a431d574ed3)</span></li>
<li>src/kpasswdserver/kpasswdserver.desktop <span style="color: grey">(486c5d5e6f61397f1ca927d78c74a6c87aae8197)</span></li>
<li>src/kssld/CMakeLists.txt <span style="color: grey">(06fccaa69e9c46d896d45f7d5dd993d2b84615ff)</span></li>
<li>src/kssld/kssld.desktop <span style="color: grey">(bc3630f0e23d1de7c274d8329b3dac7ed5e0ec8e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118472/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>