<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118473/">https://git.reviewboard.kde.org/r/118473/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 7eea5dcc160d7cd670b10bda9cad5dce2db8e180 by Marco Martin to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 2nd, 2014, 4:07 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated June 2, 2014, 4:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In relation to https://bugs.kde.org/show_bug.cgi?id=334767
seems that kio::file_copy calls fail because a wrong If-Modified-Since: is sent in the request header and the answer is almost always 304 not modified.
I compared the http kioslave with the kde4 version, and i seen that it used to reset m_request.cacheTag.servedDate
m_request.cacheTag.lastModifiedDate and m_request.cacheTag.expireDate in HTTPProtocol::sendQuery()
This has been removed in the Kf5 port, but if i restore it, KIO::file_copy seems to work correctly again</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/http/http.cpp <span style="color: grey">(c81ad41)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118473/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>