<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118289/">https://git.reviewboard.kde.org/r/118289/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The original screen shot looks bad, because the bold font looks smaller than the normal font. This might be because of wrong hinting settings, or because of a bad font design.
Regarding the scaling factor, CSS recommends 1.2 between sizes.
Could you also check, whether it reacts to font size changes?
Additionally, a programmer might be surprised, that the specified font size is not respected, so you either need to clarify in the API docs, or create a method "setFontSizeFactor()", which defaults to 1.2, but can be changed back to 1.0.</pre>
<br />
<p>- Christoph Feck</p>
<br />
<p>On May 26th, 2014, 10 a.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability and Christoph Feck.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated May 26, 2014, 10 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change titlewidget from bold to increased font size
This patch removes the bold weight from KTitleWidget and makes the text
a bit bigger, improving focus. This is more in line with common
expectations of a title, and it's more in line with Plasma 5's
typography.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ktitlewidget.cpp <span style="color: grey">(b1f3ca714670a6eaa49048d67221d90d11480cec)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118289/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/1f207a1c-eeee-4581-9f75-b2ff87671ee0__titlewidget-ss-before.png">titlewidget in systemsettings (before)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/0c07a018-cd56-4111-bda6-aafb1ebdcbc1__titlewidget-ss-after.png">titlewidget in systemsettings (after)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/a3ce0956-4339-495e-9775-e9625b4e0311__titlewidget-kate-before.png">titlewidget in kate (before)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png">titlewidget in kate (after)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>