<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118289/">https://git.reviewboard.kde.org/r/118289/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 24th, 2014, 1:57 a.m. UTC, <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118289/diff/1/?file=274659#file274659line44" style="color: black; font-weight: bold; text-decoration: underline;">src/ktitlewidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"QLabel { font-weight: bold; color: %1}"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">q</span><span class="o">-></span><span class="n">palette</span><span class="p">().</span><span class="n">color</span><span class="p">(</span><span class="n">QPalette</span><span class="o">::</span><span class="n">WindowText</span><span class="p">).</span><span class="n">name</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="kt">int</span> <span class="n">fontSize</span> <span class="o">=</span> <span class="n">qRound</span><span class="p">(</span><span class="n">QApplication</span><span class="o">::</span><span class="n">font</span><span class="p">().</span><span class="n">pointSize</span><span class="p">()</span> <span class="o">*</span> <span class="mf">1.3</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you at least make this a bit less "magical"? Right now it's just "size * 1.3".. Why 1.3? What is the basis behind it besides that it looks good in your opinion? Please do this in some generic KDE wide define or perhaps even an environment variable. For example "KDE_INCREASE_FONT_FACTOR = 1.3" that way it is clear what you mean and somewhat more discoverable and can be tweaked by users/distros if they feel the need.
Note: imho you can drop the "Font settings" title and all the titles in every KTile* since it doesn't seem to add much info. You select the "Fonts" in the left menu anyway so it is common sense that you get "<selected name> settings" in the right pane.. But that's just my opinion for that :)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's a setting purely for KTitleWidget, it would not be used elsewhere, therefore it doesn't make sense to make this dynamic.
As to your "Note:", that's unrelated, but I noticed as well. See https://git.reviewboard.kde.org/r/118290/</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On May 26th, 2014, 9:58 a.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated May 26, 2014, 9:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change titlewidget from bold to increased font size
This patch removes the bold weight from KTitleWidget and makes the text
a bit bigger, improving focus. This is more in line with common
expectations of a title, and it's more in line with Plasma 5's
typography.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ktitlewidget.cpp <span style="color: grey">(b1f3ca714670a6eaa49048d67221d90d11480cec)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118289/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/1f207a1c-eeee-4581-9f75-b2ff87671ee0__titlewidget-ss-before.png">titlewidget in systemsettings (before)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/0c07a018-cd56-4111-bda6-aafb1ebdcbc1__titlewidget-ss-after.png">titlewidget in systemsettings (after)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/a3ce0956-4339-495e-9775-e9625b4e0311__titlewidget-kate-before.png">titlewidget in kate (before)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png">titlewidget in kate (after)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>